Add a derive macro for setting fields #105
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I documented the macro a bit in the
charming-derive/src/lib.rs
file. A well formatted version can be seen when usingcargo doc
. You can check what the macro expands to when usingcargo expand --test derive_test
in thecharming-derive
folder.Current implementation
Implementation with the macro
I also added two field attributes
charming_type
andcharming_skip_setter
, their uses can be seen belowThis is just a draft. I will implement more tests first and then open another PR where we derive the new macro on all applicable structs. Just want to get some feedback on potential issues and thoughts first.
Furthermore, I expect little to no breaking changes for the user when switching to this implementation.